fix(work): stop Grok hooks treating home roster as a project - #537
Merged
Conversation
Require .brigade/config.json via shared resolve_wired_target and brigade work resolve-target so ~/.brigade never becomes a brief target (#536). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_wired_targetrequires.brigade/config.json(Claude hooks + new CLI);~/.brigaderoster-only dirs are never a work targetbrigade work resolve-target --cwd PATH [--harness NAME]so shell hooks cannot reimplement discovery wrongFixes #536
Test plan
pytest tests/test_wiring_resolve_target.py tests/test_claude_hooks_runtime.py -q(viabrigade work verify run)brigade work resolve-target --cwd $HOME/ unwired dirs → exit 1brigade work resolve-target --cwd <wired-repo> --harness grok→ that repo$HOMEno longer backgroundswork brief --target $HOME~/.grok/hooks/brigade-work.shfrom the shipped template (or reinstall when a managed Grok hooks path lands)Made with Cursor